frontend Sidebar: Improve performance by moving isSelected logic to the parent component#2638
Merged
frontend Sidebar: Improve performance by moving isSelected logic to the parent component#2638
Conversation
sniok
force-pushed
the
sidebar-perf
branch
2 times, most recently
from
6b65c95 to
11382dd
Compare
dosubot
bot
added
the
size:L
illume
requested changes
Dec 30, 2024
Contributor
illume
left a comment
illume
left a comment
There was a problem hiding this comment.
Thanks.
I left some notes.
Can you please leave in the PR description how to test?
frontend/src/components/Sidebar/__snapshots__/Sidebaritem.SublistExpanded.stories.storyshot
Outdated
Show resolved
Hide resolved
dosubot
bot
added
size:M
Change logic that determines if the item is selected to the parent component. This allows for better memoization of individual items. Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Contributor
|
I added a how to test section to the PR description. |
illume
approved these changes
Jan 7, 2025
Contributor
illume
left a comment
illume
left a comment
There was a problem hiding this comment.
👍 thanks! Nice improvement.
dosubot
bot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change only items that were updated will rerender
How to test